| commit | f618651c09a268661eb0994bd21bd6c4c93da730 | [log] [tgz] |
|---|---|---|
| author | Rob Findley <rfindley@google.com> | Mon Jan 11 10:20:27 2021 -0500 |
| committer | Robert Findley <rfindley@google.com> | Tue Jan 12 21:35:00 2021 +0000 |
| tree | 755c34b99522592fc6de6730dd1d3cddcccf4922 | |
| parent | 7646fae968264ca571f3216020863af348bb8300 [diff] |
internal/lsp/cache: compare file size when invalidating file cache Our filesystem caching layer uses file modification time to invalidate file contents. This is an imperfect heuristic, and on certain operating systems with low resolution filesystem clocks (such as WSL), this can be broken in practice. A proper fix would be to just read the file contents directly and rely on the snapshot to optimize file access, but we don't know that this is a safe change. Instead, try to reduce the likelihood of false cache hits by also checking the file size reported by Stat. For golang/go#43554 Change-Id: I1af384db532725e84fa6f3a2e5469d10b43fee92 Reviewed-on: https://go-review.googlesource.com/c/tools/+/283053 Run-TryBot: Robert Findley <rfindley@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org> Trust: Robert Findley <rfindley@google.com>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc and vet for example, are included in binary Go distributions.
Others, including the Go guru and the test coverage tool, can be fetched with go get.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/.... You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools.
This repository uses prettier to format JS and CSS files.
The version of prettier used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.