| commit | b4fe758a9b60daf80b5d17353c3f5c58114cc7ef | [log] [tgz] |
|---|---|---|
| author | Rob Findley <rfindley@google.com> | Thu Jan 30 12:25:09 2020 -0500 |
| committer | Robert Findley <rfindley@google.com> | Fri Jan 31 15:48:08 2020 +0000 |
| tree | b88ceb4de52b147b050dfd3b7d6ab87ba077f315 | |
| parent | 097c1f2eed26b3d8d6422e51ee741bd08a06b410 [diff] |
internal/lsp/source: don't allow mutating DefaultOptions DefaultOptions was a value type, but held map values. This CL changes it to a function that returns an Options value that has new instances of all reference types. It would be better if this function returned a pointer, but that change ended up being too large. I will need to refactor handling of options later anyway, in order to support sessions with differing options for golang.org/issues/34111. This fixes a race in internal/lsp/tests: internal/hooks/analysis.go mutates the Analyzers map. See for example the trybots result at: https://storage.googleapis.com/go-build-log/0d34f5f0/linux-amd64-race_4ecdf9c8.log Change-Id: I41be450b590a3f3104ac9a1cb9cb312ea3ff7ff4 Reviewed-on: https://go-review.googlesource.com/c/tools/+/217077 Run-TryBot: Robert Findley <rfindley@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org> Reviewed-by: Heschi Kreinick <heschi@google.com>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc and vet for example, are included in binary Go distributions.
Others, including the Go guru and the test coverage tool, can be fetched with go get.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/.... You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.