commit | 94327d32cf5bf14ddc9611415d1aae2e05867c84 | [log] [tgz] |
---|---|---|
author | Rob Findley <rfindley@google.com> | Tue Mar 02 10:42:44 2021 -0500 |
committer | Robert Findley <rfindley@google.com> | Tue Mar 02 17:53:15 2021 +0000 |
tree | 24ebf03937e4e7772cd59a364c2018494158381c | |
parent | 16b2c8703f0724ad926b96688c79694244f278ff [diff] |
internal/lsp/cache: show type errors on parse errors in other files CL 295414 suppressed all type checking errors in the presence of parser errors, but this was a bit overzealous. go/types attempts to suppress follow-on errors from bad syntax, so as long as we haven't had to modify the AST and the current file parses, type checking errors can still provide a decent signal to the user Fixes golang/go#44736 Change-Id: Icd89404fbae663b8f934a38908eaaa87c561b64a Reviewed-on: https://go-review.googlesource.com/c/tools/+/297872 Trust: Robert Findley <rfindley@google.com> Run-TryBot: Robert Findley <rfindley@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Heschi Kreinick <heschi@google.com>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc
and vet
for example, are included in binary Go distributions.
Others, including the Go guru
and the test coverage tool, can be fetched with go get
.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/...
. You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools
.
This repository uses prettier to format JS and CSS files.
The version of prettier
used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.