tree 4bad26ccf02a8562d4e2a3f1bd5b6e0ac8dd2e93
parent 8ec40b5329cf140bc107e373d586d32e8871bf85
author Alan Donovan <adonovan@google.com> 1652199533 -0400
committer Alan Donovan <adonovan@google.com> 1652290983 +0000

internal/lsp: fix source.CompareDiagnostic asymmetry

In passing I noticed that this three-way comparison
is not (anti)symmetric. Such comparisons should consist
of a list of pairs of tests of this form:

  if x.key1 < y.key1 { return -1 }
  if x.key1 > y.key1 { return +1 }
  ...key2, etc...
  return 0

Also in passing:
- simplify panic-proof debug string function.
- augment doc comment of (*Server).beginFileRequest

Change-Id: Idcd0844ea4e96fc2dee5bbc270f5a200b5c27aa0
Reviewed-on: https://go-review.googlesource.com/c/tools/+/405480
Reviewed-by: Robert Findley <rfindley@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Robert Findley <rfindley@google.com>