tree 98ca6d3f206b1bbf843ffb0642aa11fc3516a585
parent a9b2439b862eccc29e5ed35012352ed4e888b6f5
author Rob Findley <rfindley@google.com> 1694794395 -0400
committer Robert Findley <rfindley@google.com> 1695074895 +0000

gopls/internal/lsp/tests: eliminate several old marker types

This CL is the unraveling of a single thread, which ended up spanning
many different tests and markers. The goal was to eliminate the three
remaining diagnostic markers in the old test framework, but due to the
tightly bound nature of the old marker tests, that led to the
elimination of Diagnostics, Definitions, TypeDefinitions, and
UnimportedCompletions, along with the definition of several new markers
in the new marker tests.

The new tests are perhaps cleaner in some areas, but still a tangle: my
goal is to delete the old marker tests ASAP, and it's easier to port
them more-or-less faithfully rather than read through and fix bugs /
broken assertions, verbose APIs, unexpected diagnostics, etc.

To this end, the -ignore_extra_diags flag is introduced as some of the
old tests had too many diagnostics for me to annotate. At least this
looseness is contained only to the tests in which the flag is set.

Also, the @rank and @snippet markers didn't make a ton of sense to me
(they refer to completion items but only care about labels), but I
didn't want to fix that. At a later time, I may go back through and
change the way completion items are represented: the current style is
rather verbose.

Some completion markers in the old framework were changing settings for
each mark, sometimes applying _multiple_ settings (see signatureHelp).
The new marker framework does not support this (rightly so, in my opinion),
and so where appropriate certain tests such as unimported completion
had to be moved into a different test file so that they can use
different settings.

As for the tests themselves: they are _mostly_ the same as before,
though I had to tweak them in various small ways to make them work. For
example annotating diagnostics, redefining an import, changing the
marker signature, etc. I don't think I meaningfully changed the test
assertions, but I don't expect this to be carefully verified during
review. I can only hope that the new state is slightly more maintainable
than the old; and provides us a platform to eventually make the tests
significantly more maintainable.

For golang/go#54845

Change-Id: I701bfcbfecf32cd780caba9e324a134e2d9bd048
Reviewed-on: https://go-review.googlesource.com/c/tools/+/528736
Reviewed-by: Alan Donovan <adonovan@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>