commit | 915f6209478fe61eb90dbe155a8a1c58655b931f | [log] [tgz] |
---|---|---|
author | Cuong Manh Le <cuong.manhle.vn@gmail.com> | Thu Sep 09 20:19:43 2021 +0700 |
committer | Cuong Manh Le <cuong.manhle.vn@gmail.com> | Sat Sep 11 04:35:30 2021 +0000 |
tree | 3ea46e9122223f4ec2f771aeaa348d0a5b374c02 | |
parent | a568412ca0e6c93169269ece67db354efa879168 [diff] |
go/ssa: fix slice to array ptr conversions for named type When checking for slice to array ptr conversion, we need to check for pointer elem underlying type, otherwise, for named type, the conversion will panic. This is the same as what cmd/compile and go/types do. Fixes golang/go#48281 Change-Id: I9c35fd9a73ffd8b02917397c6a79629f63bb049b Reviewed-on: https://go-review.googlesource.com/c/tools/+/348511 Trust: Cuong Manh Le <cuong.manhle.vn@gmail.com> Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Tim King <taking@google.com>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc
and vet
for example, are included in binary Go distributions.
Others, including the Go guru
and the test coverage tool, can be fetched with go get
.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/...
. You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools
.
This repository uses prettier to format JS and CSS files.
The version of prettier
used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.