tree 7f2c52c2ee451f395f111f6dd816eacbd6a13d10
parent c88116862257841c68bf0f50226c9484abf120fa
author Robert Findley <rfindley@google.com> 1677893935 -0500
committer Robert Findley <rfindley@google.com> 1678894529 +0000

gopls/internal/lsp/cache: skip object resolution during parsing

Now that the analysis pass is isolated from other type-checking, we can
skip syntactic object resolution when parsing, saving CPU and
allocation.

To do this, eliminate the source.ParseMode type in favor of passing in
explicit parser.Mode values. Keep the source.ParseHeader and
source.ParseFull values as special parser modes.

Also:
- Fix a latent bug in parseGoURI, where the mode was not being passed
  forward
- Remove the parser mode from syntax package, as it is always
  source.ParseFull
- Fix one case where we were relying on ast.File.Scope to determine
  available identifiers. This logic was not correct in any case, as it
  should have been looking in the package scope, not the file scope.

Updates golang/go#57987

Change-Id: I25b35ee844d0e7e1f6421868beece3d1ac73eea0
Reviewed-on: https://go-review.googlesource.com/c/tools/+/473162
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Alan Donovan <adonovan@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
Run-TryBot: Robert Findley <rfindley@google.com>