tree 464dac3d103a0ab51a7b92cca08bd153d9dacfca
parent 825cb0626375eeecd4d401e7f1653c1ec405d2c8
author Rebecca Stambler <rstambler@golang.org> 1576169633 -0500
committer Rebecca Stambler <rstambler@golang.org> 1576182696 +0000

go/packages: disable -mod=readonly behavior in overlays

This was preventing mod files from being updated when dependencies were
added to overlays. This prevents gopls from accurately modifying a user's
mod file when a dependency is added, which poses problems for usability.
To handle the issues that this was (supposedly) solving, we can require
that files from multiple modules are never added in an overlay.

For some reason, this doesn't break TestOverlayModFileChanges.

Change-Id: I24d6c30754c2bebc440802f7cf2931d98e450ebf
Reviewed-on: https://go-review.googlesource.com/c/tools/+/211058
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Michael Matloob <matloob@golang.org>