| commit | 8e32e9f144bc0fca3fc5c250127f11a540c06345 | [log] [tgz] |
|---|---|---|
| author | Rob Findley <rfindley@google.com> | Fri Jul 09 12:14:13 2021 -0400 |
| committer | Robert Findley <rfindley@google.com> | Fri Jul 09 17:21:04 2021 +0000 |
| tree | 3ed83c2c3c04f9ec77de7f9b134b34de4bc0ce86 | |
| parent | 2583041a9ded1b6efc6612d7d0743a42a00dde99 [diff] |
internal/lsp/regtest: fix a panic TestResolveImportCycle CL 333289 introduced a panic, which was subsequently suppressed in test error output due to the deferred t.Fatal (an interesting gotcha that I honestly wasn't aware of). Fix both the panic, and the suppression of regtest panics. Also fix the regtest editor shutdown to run on a detached context, so that shutdown doesn't fail for tests that have timed out. For golang/go#46773 Change-Id: I080a713ae4cd4651476d8b4aab1d2291754a4f5a Reviewed-on: https://go-review.googlesource.com/c/tools/+/333510 Trust: Robert Findley <rfindley@google.com> Run-TryBot: Robert Findley <rfindley@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc and vet for example, are included in binary Go distributions.
Others, including the Go guru and the test coverage tool, can be fetched with go get.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/.... You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools.
This repository uses prettier to format JS and CSS files.
The version of prettier used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.