| commit | 4c025a95b26e43a32c527d23a8a7ed074723e03b | [log] [tgz] |
|---|---|---|
| author | Michael Matloob <matloob@golang.org> | Fri Oct 11 16:49:23 2019 -0400 |
| committer | Michael Matloob <matloob@golang.org> | Fri Oct 11 21:18:36 2019 +0000 |
| tree | 8a9715c2982958fe4bce8b9e46a488a7647c1f29 | |
| parent | 7667e13ae93cf685de54af2caca6678d9f7618be [diff] |
go/packages: make a copy of the config.Env slice in the test.
Before this change, we were "saving" config.Env and then appending
to it to create a new slice, like so:
savedEnv := config.Env
...
// for each test case
config.Env = append(savedEnv, additionalValue)
but we're modifying savedEnv during each env. Even though it might
work, it's not doing what we expect. Clean this up.
Change-Id: Idcf8199d836241df2b934308863512c566c0c485
Reviewed-on: https://go-review.googlesource.com/c/tools/+/200769
Run-TryBot: Michael Matloob <matloob@golang.org>
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc and vet for example, are included in binary Go distributions.
Others, including the Go guru and the test coverage tool, can be fetched with go get.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/.... You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.