tree d04a096996705b24196f7e148f0bb7a2152e9c9f
parent 8a9a89368bd3a1133a785181d9e4941e9353137f
author Danish Dua <danishdua@google.com> 1600982718 -0400
committer Danish Dua <danishdua@google.com> 1600987342 +0000

internal/lsp: move package selection to before type checking

This change moves package selection to before type checking so we don't
unnecessarily type-check both variants of a package. As a result, exec
time and memory usage for features making calls to GetParsedFile are cut
by half since we only type check either the narrowest or the widest
package.

Change-Id: Ifd076f8c38e33de2bd3509fe17feafccd59d7419
Reviewed-on: https://go-review.googlesource.com/c/tools/+/257240
Run-TryBot: Danish Dua <danishdua@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Trust: Danish Dua <danishdua@google.com>
Reviewed-by: Heschi Kreinick <heschi@google.com>