commit | 0b86805daf587a233776bf85a62824ed213101d7 | [log] [tgz] |
---|---|---|
author | Rob Findley <rfindley@google.com> | Tue Oct 27 16:58:39 2020 -0400 |
committer | Robert Findley <rfindley@google.com> | Tue Oct 27 23:31:11 2020 +0000 |
tree | 0b2022c2b5db42ee311fe1f14d2787ddf772044a | |
parent | 6312208388417220cdb035180d08b973c0d3fd20 [diff] |
internal/lsp: finish work when synchronous commands complete Synchronous commands were bypassing the logic to handle the command error an publish a final workDoneProgressEnd message. Push this logic down into Server.runCommand. Also, switch 'generate' to be synchronous, since this makes sense and causes the synchronous path to be exercised in tests. Finally, stop defaulting the command title to Command.Name. All Commands should have Titles. Change-Id: Id0b1e5283e54d82c307e933782317372bd8971af Reviewed-on: https://go-review.googlesource.com/c/tools/+/265737 Run-TryBot: Robert Findley <rfindley@google.com> Reviewed-by: Heschi Kreinick <heschi@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org> Trust: Robert Findley <rfindley@google.com>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc
and vet
for example, are included in binary Go distributions.
Others, including the Go guru
and the test coverage tool, can be fetched with go get
.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/...
. You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools
.
This repository uses prettier to format JS and CSS files.
The version of prettier
used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.