commit | 2db1cd79103977d245650c90d9f2a5c0d591c152 | [log] [tgz] |
---|---|---|
author | Rebecca Stambler <rstambler@golang.org> | Thu Oct 08 22:37:50 2020 -0400 |
committer | Rebecca Stambler <rstambler@golang.org> | Tue Oct 13 05:33:47 2020 +0000 |
tree | 6d36780fc573bafea69b57a5747d05088de20b63 | |
parent | ec925d8b1dc677f68459b76cf257574a0678bc75 [diff] |
internal/lsp: extract mod errors in load and treat them like diagnostics This change pulls out the logic to process module-related errors from go/packages.Load out of internal/lsp and into internal/lsp/cache. This simplifies diagnostic handling in internal/lsp, as we can just return a *source.ErrorList. Most of this is just a code move, not really a logical change. This also fixes the staticcheck error :) Change-Id: Ic6cad3f59a7e4492dea85b8dcfa9e3f24a371803 Reviewed-on: https://go-review.googlesource.com/c/tools/+/260805 Trust: Rebecca Stambler <rstambler@golang.org> Run-TryBot: Rebecca Stambler <rstambler@golang.org> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Robert Findley <rfindley@google.com>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc
and vet
for example, are included in binary Go distributions.
Others, including the Go guru
and the test coverage tool, can be fetched with go get
.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/...
. You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools
.
This repository uses prettier to format JS and CSS files.
The version of prettier
used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.