| commit | 8aba49bb5ea283ececf5e8a1652b5e9705115d37 | [log] [tgz] |
|---|---|---|
| author | Alan Donovan <adonovan@google.com> | Mon Jan 09 13:44:29 2023 -0500 |
| committer | Alan Donovan <adonovan@google.com> | Tue Jan 17 18:02:57 2023 +0000 |
| tree | 08510602afd4d50583233b79a5703731a726419d | |
| parent | d7fc4e7114a478d21092b3ab0ce243607ce74c34 [diff] |
internal/gcimporter: preserve column and line in shallow iexport Historically, export data has discarded source position information. Originally not even line numbers were available; at some point line and column numbers were stored, up to some fixed limit, but more recently column numbers were again discarded. Offset information has always been incorrect. gopls is moving toward greater reliance on incremental operation using a file-based cache of export data and other serializable records that are similar in character. It is critical that it be able to accurately recover file position information for dependencies. This change causes the iexport function to encode each object's token.Pos as a pair (file, offset), where file indicates the token.File and offset is a byte offset within the file. The token.File is serialized as a filename and a delta-encoded line-offset table. (We discard the lineInfos table that supports //line directives because gopls no longer uses it.) The iimport function constructs a token.File and calls SetLines, and then all token.Pos values work exactly as they would with source. This causes about a 74% increase in size of the shallow export data for the standard library: was 564KB, now 982KB. token.File has a SetLines method but no GetLines. This change must therefore resort to... unorthodox methods to retrieve the field. Suggestions welcome. This alternative encoding is enabled by using "shallow" mode, which is effectively a license for gopls to do whatever it wants. Again, suggestions welcome. Updates golang/go#57708 Change-Id: I028ed669161e38a9a4672dd8d9cadb268a0cdd07 Reviewed-on: https://go-review.googlesource.com/c/tools/+/461215 Run-TryBot: Alan Donovan <adonovan@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Robert Findley <rfindley@google.com>
This repository provides the golang.org/x/tools module, comprising various tools and packages mostly for static analysis of Go programs, some of which are listed below. Use the “Go reference” link above for more information about any package.
It also contains the golang.org/x/tools/gopls module, whose root package is a language-server protocol (LSP) server for Go. An LSP server analyses the source code of a project and responds to requests from a wide range of editors such as VSCode and Vim, allowing them to support IDE-like functionality.
Selected commands:
cmd/goimports formats a Go program like go fmt and additionally inserts import statements for any packages required by the file after it is edited.cmd/callgraph prints the call graph of a Go program.cmd/digraph is a utility for manipulating directed graphs in textual notation.cmd/stringer generates declarations (including a String method) for “enum” types.cmd/toolstash is a utility to simplify working with multiple versions of the Go toolchain.These commands may be fetched with a command such as
go install golang.org/x/tools/cmd/goimports@latest
Selected packages:
go/ssa provides a static single-assignment form (SSA) intermediate representation (IR) for Go programs, similar to a typical compiler, for use by analysis tools.
go/packages provides a simple interface for loading, parsing, and type checking a complete Go program from source code.
go/analysis provides a framework for modular static analysis of Go programs.
go/callgraph provides call graphs of Go programs using a variety of algorithms with different trade-offs.
go/ast/inspector provides an optimized means of traversing a Go parse tree for use in analysis tools.
go/cfg provides a simple control-flow graph (CFG) for a Go function.
go/expect reads Go source files used as test inputs and interprets special comments within them as queries or assertions for testing.
go/gcexportdata and go/gccgoexportdata read and write the binary files containing type information used by the standard and gccgo compilers.
go/types/objectpath provides a stable naming scheme for named entities (“objects”) in the go/types API.
Numerous other packages provide more esoteric functionality.
This repository uses Gerrit for code changes. To learn how to submit changes, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.
This repository uses prettier to format JS and CSS files.
The version of prettier used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.