| commit | 8a6051197512ff9cbf65108d80613b631fe0b4f3 | [log] [tgz] |
|---|---|---|
| author | Heschi Kreinick <heschi@google.com> | Thu Jan 03 13:53:54 2019 -0500 |
| committer | Heschi Kreinick <heschi@google.com> | Thu Jan 03 20:59:43 2019 +0000 |
| tree | 9980191d3bb48e7b231115a935a49c4e36077339 | |
| parent | ca9055ed7d0470e61b81778f76637846e891ff60 [diff] |
imports: don't look for, or find, empty packages Fix a pair of bugs that combined to cause golang/go#29520. First, don't go looking for a package if we've only seen unexported identifiers selected from it. It's probably a typo. Second, don't find packages with no files in them, e.g. because they're all build tagged out. We can't know what package they form, so we have no business considering them. Test only for the first, since without the first bug the second has no observable effect on behavior, and I don't want to test the private API. Fixes golang/go#29520 Change-Id: I5b797940bec051be5945b9c5cb4e7bf28527a939 Reviewed-on: https://go-review.googlesource.com/c/156178 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc and vet for example, are included in binary Go distributions.
Others, including the Go guru and the test coverage tool, can be fetched with go get.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/.... You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.