commit | 8938cee73c2baa24cd58a044a94f5da9acfc43e1 | [log] [tgz] |
---|---|---|
author | Muir Manders <muir@mnd.rs> | Tue Feb 02 22:29:19 2021 -0800 |
committer | Rebecca Stambler <rstambler@golang.org> | Fri Feb 05 19:39:40 2021 +0000 |
tree | a9baa55749cc60700f923abb7343aa9d76086529 | |
parent | c3a8a1d82834956d976acb2cecce7e10d68f8b9c [diff] |
internal/lsp/completion: fix invalid struct literal field snippet In cases like: type foo struct { a int; b float64 } foo{b<>} We were completing to "foo{int(b: <float64>)}" (the problem being the nonsensical int() conversion). The expected type at "<>" is int to allow completions to match "a". When we pass the *types.Var representing "b" through the candidate matching machinery, we say "Oh, a float64! I can convert that to my expected type of int!". Fix by bailing out of candidate matching early if the candidate is a composite literal struct field name. Field names aren't really objects you can do anything to. Fixes golang/go#43789. Change-Id: Ie4dab166973dfcdcb519f864532ead1f792d25a3 Reviewed-on: https://go-review.googlesource.com/c/tools/+/289130 Run-TryBot: Muir Manders <muir@mnd.rs> Run-TryBot: Rebecca Stambler <rstambler@golang.org> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org> Trust: Rebecca Stambler <rstambler@golang.org> Trust: Hyang-Ah Hana Kim <hyangah@gmail.com>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc
and vet
for example, are included in binary Go distributions.
Others, including the Go guru
and the test coverage tool, can be fetched with go get
.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/...
. You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools
.
This repository uses prettier to format JS and CSS files.
The version of prettier
used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.