godoc: be quiet by default about bad examples
Fixes golang/go#6759
R=golang-dev, adg, rsc
CC=golang-dev
https://golang.org/cl/26420044
diff --git a/godoc/server.go b/godoc/server.go
index 95f4397..dd3887a 100644
--- a/godoc/server.go
+++ b/godoc/server.go
@@ -131,7 +131,7 @@
if err != nil {
log.Println("parsing examples:", err)
}
- info.Examples = collectExamples(pkg, files)
+ info.Examples = collectExamples(h.c, pkg, files)
// collect any notes that we want to show
if info.PDoc.Notes != nil {
@@ -320,7 +320,7 @@
}
// collectExamples collects examples for pkg from testfiles.
-func collectExamples(pkg *ast.Package, testfiles map[string]*ast.File) []*doc.Example {
+func collectExamples(c *Corpus, pkg *ast.Package, testfiles map[string]*ast.File) []*doc.Example {
var files []*ast.File
for _, f := range testfiles {
files = append(files, f)
@@ -332,7 +332,7 @@
name := stripExampleSuffix(e.Name)
if name == "" || globals[name] {
examples = append(examples, e)
- } else {
+ } else if c.Verbose {
log.Printf("skipping example 'Example%s' because '%s' is not a known function or type", e.Name, e.Name)
}
}
