tree b4ff3d508bbadbee5c7e3446f1f63d877f5e24aa
parent 8a18b87bf6638fba3046ba9db683a3b7a13756fb
author Muir Manders <muir@mnd.rs> 1568774921 -0700
committer Rebecca Stambler <rstambler@golang.org> 1570046865 +0000

internal/lsp: don't overwrite suffix when inserting completion

In cases like "fmt.Pr<>int()" we previously would replace "Print" with
the new completion, yielding for example "fmt.Println()". Now we no
longer overwrite, yielding "fmt.Println()int()". There are some cases
where overwriting the suffix is what the user wants, but it is hard to
tell, so for now stick with the more expected behavior of not
overwriting.

Fixes golang/go#34011.

Change-Id: I8c3ccd8948245c27b52408ad508d8e01dc163ef4
Reviewed-on: https://go-review.googlesource.com/c/tools/+/196119
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>