|author||Heschi Kreinick <firstname.lastname@example.org>||Mon Nov 09 12:46:32 2020 -0500|
|committer||Heschi Kreinick <email@example.com>||Mon Nov 09 18:10:55 2020 +0000|
internal/lsp/source: don't find possible interface references to types In CL 259998 we added the ability to find calls to methods through interfaces. That included very common interfaces like Stringer, which we judged unfortunate but possibly acceptable. We didn't consider the behavior when searching for references to a type. When searching for references to a type that happens to be a Stringer, the user almost certainly doesn't want to see all uses of the Stringer interface. Don't consider interface references to types. No tests; I don't think this is worth a regtest and the marker tests can't check a negative AFAIK. Fixes golang/go#42350. Change-Id: I0b929d8743f7f0b4e7543e8d35921a7cf3784bf5 Reviewed-on: https://go-review.googlesource.com/c/tools/+/268462 Trust: Heschi Kreinick <firstname.lastname@example.org> Run-TryBot: Heschi Kreinick <email@example.com> gopls-CI: kokoro <firstname.lastname@example.org> Reviewed-by: Robert Findley <email@example.com> TryBot-Result: Go Bot <firstname.lastname@example.org>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools,
vet for example, are included in binary Go distributions.
Others, including the Go
guru and the test coverage tool, can be fetched with
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run
go get -u golang.org/x/tools/.... You can also manually git clone the repository to
This repository uses prettier to format JS and CSS files.
The version of
prettier used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.