| commit | 84e69e7d4f6adbb082b4e835299445b6be1b8f84 | [log] [tgz] |
|---|---|---|
| author | Andrew Wansink <wansink@uber.com> | Wed Nov 03 18:33:45 2021 +0000 |
| committer | Tim King <taking@google.com> | Wed Nov 03 20:51:16 2021 +0000 |
| tree | 55567b806d7aa7b24188cd4ad225f9aa03c96b87 | |
| parent | 68536facc95c8f6b55fe232c10c627b251190dcf [diff] |
go/analysis/passes/copylock: detect copylock in multi-assignment The existing implementation does not identify lock copies when doing multi-assignment, i.e. foo, ok := someMap["key"] Currently, it will find issue with similar code foo := someMap["key"]. This discrepency is because a return type of Tuple was not considered when resolving the type of the right hand side of the assignment. Fixes #45896 Change-Id: I93266dbd03a301ff558d826ff4fe70fc0344cb77 GitHub-Last-Rev: bb51bdd664b060e481ce0091701ed3470558cf0f GitHub-Pull-Request: golang/tools#319 Reviewed-on: https://go-review.googlesource.com/c/tools/+/323589 Run-TryBot: Tim King <taking@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Tim King <taking@google.com> Trust: Robert Findley <rfindley@google.com>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc and vet for example, are included in binary Go distributions.
Others, including the Go guru and the test coverage tool, can be fetched with go install.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go install golang.org/x/tools/...@latest.
This repository uses prettier to format JS and CSS files.
The version of prettier used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.