tree 01a73357abf1acd67edf1cb2d9924a2890dda307
parent 6e6f73a58b5309434020f8e109a5b3f5cff8b839
author Heschi Kreinick <heschi@google.com> 1602711676 -0400
committer Heschi Kreinick <heschi@google.com> 1602783843 +0000

internal/lsp: fix env setting type

We stored the user's environment settings as a string slice, but users
set it as a map. It turns out that we have code spread around to convert
it both back and forth, so rather than hack up the doc generator,
so centralize that code and change the native representation to a map.
We end up with slightly less code.

Fixes golang/go#41964.

Change-Id: I975c69524c7d79c7d09079f44cc44a27e72ba285
Reviewed-on: https://go-review.googlesource.com/c/tools/+/262351
Trust: Heschi Kreinick <heschi@google.com>
Run-TryBot: Heschi Kreinick <heschi@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>