tree c2a960a4935279612fda45bda8bb2c747c465c01
parent 9dfac01ddd86037d8f36e89051430ce31f180597
author Fernandez Ludovic <lfernandez.dev@gmail.com> 1620833394 +0200
committer Rebecca Stambler <rstambler@golang.org> 1620853188 +0000

go/analysis/passes/sigchanyzer: copy to avoid modifying the AST

The sigchanyzer pass suggests fixes, but it does that
by altering the channel declaration argument.
That causes the buildssa.Analyzer fail to fail,
along with crashing other passes that depend on it.

To fix this, we make a copy of the channel's declaration arguments,
and modify the copy instead.

Fixes golang/go#46129

Change-Id: I807d36abd49cd3ccc2cc9f907aa98349b2e3231f
Reviewed-on: https://go-review.googlesource.com/c/tools/+/319211
Reviewed-by: Emmanuel Odeke <emmanuel@orijtech.com>
Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Run-TryBot: Emmanuel Odeke <emmanuel@orijtech.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Trust: Cuong Manh Le <cuong.manhle.vn@gmail.com>