tree 10c6135f0578a9ba9c6165de305029a6b5152ca6
parent 56eb7d2c19ba6b05ace11fab7ac8d090edd31eed
author Muir Manders <muir@mnd.rs> 1575916888 -0800
committer Rebecca Stambler <rstambler@golang.org> 1576127520 +0000

internal/lsp: downrank "nil" completion candidate

Having nil ranked normally causes it to show up as the top candidate
in cases like:

context.WithCancel(<>) // "nil" shows up before "context.Background()"

"context.Background()" gets a slight score penalty since it is a deep
completion, so "nil" is ranked highest.

Sometimes you do want "nil", but it's such a short identifier you
probably aren't leaning too heavily on autocompletion. I think it
makes sense to optimize for the case when you want something non-nil.

Change-Id: I537927db2b573535e751380c4cba5c9873dfe524
Reviewed-on: https://go-review.googlesource.com/c/tools/+/210539
Run-TryBot: Muir Manders <muir@mnd.rs>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>