tree 9122e0e6d9f8cc3ccff56a4acec896d751839ebc
parent dd1c468586abf42c35d01253e89b152c4d12db93
author Tim King <taking@google.com> 1635441643 -0700
committer Tim King <taking@google.com> 1675381347 +0000

go/analysis/internal/facts: fix cycle in importMap.

This change resolves two interrelated outstanding bugs in handling Named
types and type declarations in importMap().
1) Named types did not visit their Underlying() types.
2) Whether Named types were fully visited was order dependent.
   Previously a Named type was not fully visited (methods visited, etc)
   when the type declaration was visited by addObj() before the Named
   type was visited by addType().

Fixes golang/go#49469

Change-Id: Ibf9c6d9afd4958d474149edf2749d994199f14b1
Reviewed-on: https://go-review.googlesource.com/c/tools/+/362414
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Tim King <taking@google.com>
Reviewed-by: Robert Findley <rfindley@google.com>