commit | 80cb79702c9e104dd1d60dd6f521936504a2a7d2 | [log] [tgz] |
---|---|---|
author | Rebecca Stambler <rstambler@golang.org> | Tue Jul 21 02:05:22 2020 -0400 |
committer | Rebecca Stambler <rstambler@golang.org> | Thu Jul 23 19:34:40 2020 +0000 |
tree | 1007960769681f1bb8ca67f23112ea7a6cbb9bbc | |
parent | 188b38280e32592ca5fa5cdb292481164dd31218 [diff] |
internal/lsp: don't publish duplicate diagnostics in one report CL 242579 changed the mechanism of reporting diagnostics so that we now combine reports from multiple sources. Previously, we overwrote existing diagnostics if new ones were reported. This was fine because source.Diagnostics generated all of the diagnostics for Go files, and mod.Diagnostics generated all of the diagnostics for go.mod files. Now, we combine diagnostics from both sources -- mod.Diagnostics can generate reports for Go files. We may get duplicate reports for packages with test variants, so now, we check for those and dedupe. Change-Id: I42e98079b4eead380058dd029a3a0c72a1796ebb Reviewed-on: https://go-review.googlesource.com/c/tools/+/243778 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Heschi Kreinick <heschi@google.com>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc
and vet
for example, are included in binary Go distributions.
Others, including the Go guru
and the test coverage tool, can be fetched with go get
.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/...
. You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools
.
This repository uses prettier to format JS and CSS files.
The version of prettier
used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.