tree d9bb8e8cc37a31002e34526190ad55b3bf99aa79
parent 478150226d2cb1ef545b87f19b4a960008737415
author Tim Heckman <t@heckman.io> 1500258884 -0700
committer Brad Fitzpatrick <bradfitz@golang.org> 1500261655 +0000

cmd/go-contrib-init: exit with an error if package install fails

During the first run of `go-contrib-init` it tries to install the
golang.org/x/review/git-codereview package using `go get`. If this command were
to fail, we would check for the error and log that the command failed to
succeed. However, when failure occurred we would only log the error and not
interrupt the flow of the program. This would cause the program to continue with
the assumption that git-codereview had been installed correctly.

This change enhances the `go-contrib-init` command to exit with a bad status
code, after logging the failure, if installing git-codereview fails.

Fixes golang/go#21040

Change-Id: Ie01d78557d54285001db61faafbb409888b2893c
Reviewed-on: https://go-review.googlesource.com/49151
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>