tree d6e53bc7d13fe20f3864984b91d23e81b6400de1
parent e956495a7123528842a925cba81a856c53f3960f
author Robert Findley <rfindley@google.com> 1673553225 -0500
committer Robert Findley <rfindley@google.com> 1673554177 +0000

gopls/internal/regtest: eliminate NoDiagnostics

It is confusing to have both NoDiagnostics and EmptyOrNoDiagnostics.

From a user's perspective, it does not matter whether gopls sends no
diagnostics or sends empty diagnostics, so favor EmptyOrNoDiagnostics.
In a subsequent change, I will rename EmptyOrNoDiagnostics to just
NoDiagnostics.

Also, switch more Await expressions to eager failures along the way.

Change-Id: Ib20b9ad7e7e7c819f793acb931681ec0dd4f76f7
Reviewed-on: https://go-review.googlesource.com/c/tools/+/461876
Run-TryBot: Robert Findley <rfindley@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Alan Donovan <adonovan@google.com>