tree eb335f925c3225397c8c8986f70a1d8683d0c7bb
parent 50fa39b762bc2747ec16565777426e00b1b86cb8
author Bryan C. Mills <bcmills@google.com> 1573499006 -0500
committer Bryan C. Mills <bcmills@google.com> 1573500142 +0000

internal/testenv: reject the resolved 'go' command if it does not match runtime.GOROOT

Many tests in x/tools invoke the 'go' command found from $PATH.
If that command does not match the 'go' command used to invoke 'go test',
the result will be misleading.

Instead of silently accepting the mismatched result, check the 'go'
tool's self-reported GOROOT and reject it if it doesn't match the 'go'
tool used to invoke 'go test'.

That rejection will cause the x/tools tests to fail if x/tools is the main module.

Updates golang/go#35505

Change-Id: I581906468ef736fad42a0164376a07f876907621
Reviewed-on: https://go-review.googlesource.com/c/tools/+/206517
Run-TryBot: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Jay Conrod <jayconrod@google.com>