commit | 7d7faa4812bd548dafb3ef3238a968e0aa9b70d4 | [log] [tgz] |
---|---|---|
author | Muir Manders <muir@mnd.rs> | Tue May 14 03:09:27 2019 +0000 |
committer | Rebecca Stambler <rstambler@golang.org> | Wed May 15 01:24:06 2019 +0000 |
tree | 23b062881f597fedf4643e01c73525844c41bfb3 | |
parent | 921b34c7d07f74c8b33bbbfae8e373bb20929ea2 [diff] |
internal/lsp: fix missing parens in function call snippet We were omitting the parens in function completions like "(foo<>)()" because our check thought "foo" was the Fun in the outer CallExpr so it already had parens. Fix by tightening up logic to only omit parens for cases like "foo<>()" and "foo.bar<>()". Change-Id: Ia602b80275f72baa6cdf6d61c22d3f3a6cfc3019 GitHub-Last-Rev: 41fecf92617e0812ee6552d8c43789eae83889bd GitHub-Pull-Request: golang/tools#98 Reviewed-on: https://go-review.googlesource.com/c/tools/+/176944 Reviewed-by: Rebecca Stambler <rstambler@golang.org> Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc
and vet
for example, are included in binary Go distributions.
Others, including the Go guru
and the test coverage tool, can be fetched with go get
.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/...
. You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools
.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.