tree 5cc7933ab0dae748742ce6172a697900d0b1f128
parent 2f5a1a7a23ccb071b34c7e63dc1fe20680b98ba4
author Alan Donovan <adonovan@google.com> 1542216586 -0500
committer Alan Donovan <adonovan@google.com> 1542218109 +0000

go/analysis: exit nonzero upon diagnostics

This change causes singlechecker and multichecker to exit with the
correct error code: 0 for success, 1 for load/analysis and other
errors, 3 for diagnostics.  (We avoid 2 because the flag package uses
it.)

In JSON mode, errors in package loading, parsing, typechecking and
analysis are successfully in JSON format, with exit code 0.

+ Test.

Change-Id: Iaf130ed3d4cb3e747a628af6da8dc97d065aa869
Reviewed-on: https://go-review.googlesource.com/c/149603
Run-TryBot: Alan Donovan <adonovan@google.com>
Reviewed-by: Michael Matloob <matloob@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>