| commit | 7bc3c281e1f3bf5d2318c91251fb1080c6eaaacb | [log] [tgz] |
|---|---|---|
| author | Rob Findley <rfindley@google.com> | Mon Aug 09 18:41:56 2021 -0400 |
| committer | Robert Findley <rfindley@google.com> | Tue Aug 10 00:38:50 2021 +0000 |
| tree | 816b19cb2b9079d72290a46bdcf198ab63943b50 | |
| parent | 337cebd2c1515345114fbdd15101e250d1655ca7 [diff] |
internal/lsp/source: fix race in workspace symbols with multiple views Unfortunately only after merging CL 338729 did I use it in a multi-view workspace. That CL added a goroutine per matcher to scan symbols, but unfortunately did this for each view, resulting in a race if there are multiple views. The fix is straightforward. Change-Id: I405b37921883f9617f17c1e1506ff67b4c661cbc Reviewed-on: https://go-review.googlesource.com/c/tools/+/340970 Trust: Robert Findley <rfindley@google.com> Run-TryBot: Robert Findley <rfindley@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc and vet for example, are included in binary Go distributions.
Others, including the Go guru and the test coverage tool, can be fetched with go get.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/.... You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools.
This repository uses prettier to format JS and CSS files.
The version of prettier used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.