tree 016c5b6304a247840d7bfc8daa0471ed58d2b0cd
parent c6e1543aba625eb8e00a24270b07e67eb90c4108
author Paul Jolly <paul@myitcv.io> 1556559390 +0100
committer Paul Jolly <paul@myitcv.org.uk> 1556561816 +0000

internal/span: fix another off-by-one in ToUTF16Column

The current tests contain a bug in the priming of funnyString; the
subslicing leaves the resulting content slice with a capacity greater
than its length. This allowed a bug ToUTF16Column to sneak through where
we were not using 0-based column as the offset within the line.

Fix the priming of funnyString, and fix the implementation of
ToUTF16Column.

Change-Id: I2618878d85bba26f52f99a3fc136ad21fe198dfc
Reviewed-on: https://go-review.googlesource.com/c/tools/+/174357
Reviewed-by: Ian Cottrell <iancottrell@google.com>
Run-TryBot: Ian Cottrell <iancottrell@google.com>