| commit | 7ac129f24ace03f9aa0fa6097083e825536363e9 | [log] [tgz] |
|---|---|---|
| author | Rebecca Stambler <rstambler@golang.org> | Thu Jun 03 01:17:07 2021 -0400 |
| committer | Rebecca Stambler <rstambler@golang.org> | Thu Jun 03 14:48:35 2021 +0000 |
| tree | f41702d8844270841909698ef8a1f40e7772957f | |
| parent | 1c2154ae38d2f3336a2dc785168770f2f7588270 [diff] |
internal/lsp: don't diagnose/analyze intermediate test variants As part of debugging CL 324394, I found that we were returning intermediate test variant packages in packageHandlesForFile. This happened because, even though these packages were not workspace packages, they would still be picked up by the file URIs -> IDs map. This is typically not a problem when we are picking out the widest or narrowest package for a specific request, but for diagnostics on changed files, we run them on all of the possible packages. This also led to us analyzing these intermediate test variant packages. Filter them out, as we will never want them for this purpose. Change-Id: Ifa780cd104f9c4b3fe6c530402956e2337c8fcdc Reviewed-on: https://go-review.googlesource.com/c/tools/+/324689 Trust: Rebecca Stambler <rstambler@golang.org> Run-TryBot: Rebecca Stambler <rstambler@golang.org> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Robert Findley <rfindley@google.com>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc and vet for example, are included in binary Go distributions.
Others, including the Go guru and the test coverage tool, can be fetched with go get.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/.... You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools.
This repository uses prettier to format JS and CSS files.
The version of prettier used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.