)]}' { "commit": "796b347e00a4001fe37a11fe69033802fd4fce3b", "tree": "1e93d88b8c29950966ee70fa87786338e3f4c595", "parents": [ "33aa62cf854f867a1ac6daf0829182345a8acd76" ], "author": { "name": "Rebecca Stambler", "email": "rstambler@golang.org", "time": "Thu Sep 10 16:48:35 2020 -0400" }, "committer": { "name": "Rebecca Stambler", "email": "rstambler@golang.org", "time": "Sun Sep 13 03:42:12 2020 +0000" }, "message": "[gopls-release-branch.0.5] internal/lsp: handle staticcheck in didChangeConfiguration\n\nAs we have modified the ways that we control which analyzers get\nexecuted for a given case, we have lost the behavior of enabling and\ndisabling staticcheck smoothly. This CL splits out the staticcheck\nanalyzers from the main group so that the \"staticcheck\" setting can\noverride whether or not a given staticcheck analysis is enabled.\n\nFixes golang/go#41311\n\nChange-Id: I9c1695afe4a8f89cd0ee50a79e83b2f42a2c20cb\nReviewed-on: https://go-review.googlesource.com/c/tools/+/254427\nTrust: Rebecca Stambler \u003crstambler@golang.org\u003e\nRun-TryBot: Rebecca Stambler \u003crstambler@golang.org\u003e\nTryBot-Result: Gobot Gobot \u003cgobot@golang.org\u003e\nReviewed-by: Robert Findley \u003crfindley@google.com\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "f46a93f446e9ebc7755316546864c9bd5cffcb68", "old_mode": 33188, "old_path": "gopls/internal/hooks/analysis.go", "new_id": "4eb042d3a12c012e2be792524fb13c5e72b63059", "new_mode": 33188, "new_path": "gopls/internal/hooks/analysis.go" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "47dfc421ea69d8ed6d3d8ee0898af01ea426047a", "new_mode": 33188, "new_path": "gopls/internal/regtest/configuration_test.go" }, { "type": "modify", "old_id": "b84175f3d901c187d182eec5c068bcc491c30af3", "old_mode": 33188, "old_path": "gopls/internal/regtest/wrappers.go", "new_id": "7ac01a886ac89340e8550c0e77337314c20ae631", "new_mode": 33188, "new_path": "gopls/internal/regtest/wrappers.go" }, { "type": "modify", "old_id": "bfb68ab69edc386fc3b1684650436386564ad130", "old_mode": 33188, "old_path": "internal/lsp/cache/view.go", "new_id": "f3479f827d004e7f39033bec5c7d91e93b578625", "new_mode": 33188, "new_path": "internal/lsp/cache/view.go" }, { "type": "modify", "old_id": "d9b90f85729471615ba1171da63370f41b28d1b6", "old_mode": 33188, "old_path": "internal/lsp/code_action.go", "new_id": "bb76ff96f2fcce7836080db8d9c0ef34aca4ee87", "new_mode": 33188, "new_path": "internal/lsp/code_action.go" }, { "type": "modify", "old_id": "320d39bcec29c5e1ce8f2a2c8ab484e263cb34e2", "old_mode": 33188, "old_path": "internal/lsp/source/diagnostics.go", "new_id": "9f1b091f11a97c78165fed028b63739f7332093c", "new_mode": 33188, "new_path": "internal/lsp/source/diagnostics.go" }, { "type": "modify", "old_id": "dd026cbd8d8cdbf435e04c4627275899b1d0d8ec", "old_mode": 33188, "old_path": "internal/lsp/source/options.go", "new_id": "924a7ff9c8fa3c4b51e6a8aa8b1de3c51c5adb8c", "new_mode": 33188, "new_path": "internal/lsp/source/options.go" }, { "type": "modify", "old_id": "e463491cb0376fe0d9e7e976bcdfa22bc4f2fb15", "old_mode": 33188, "old_path": "internal/lsp/source/view.go", "new_id": "445d48cba883587e5665585bc83c65cebf5bb625", "new_mode": 33188, "new_path": "internal/lsp/source/view.go" }, { "type": "modify", "old_id": "fbef83594df06c755dffb9c8d37bd01822e1ed18", "old_mode": 33188, "old_path": "internal/lsp/tests/util.go", "new_id": "caa45cb4bcaa9c652ccb13d7f49128202927aa12", "new_mode": 33188, "new_path": "internal/lsp/tests/util.go" } ] }