| commit | 33aa62cf854f867a1ac6daf0829182345a8acd76 | [log] [tgz] |
|---|---|---|
| author | Rob Findley <rfindley@google.com> | Thu Sep 10 17:43:40 2020 -0400 |
| committer | Robert Findley <rfindley@google.com> | Fri Sep 11 01:00:03 2020 +0000 |
| tree | 1fafc7f181c3f3fea059e29deeaaf658ecf11124 | |
| parent | e585dae8889b8cfee4dae04eb41a32a561e74f26 [diff] |
internal/lsp/source: fix duplicates in workspaceSymbols The logic to de-dupe workspace symbols was broken in two ways: - The 'seen' map of files already processed was never written. - The key to 'seen' was *ast.File, which doesn't work if we parse twice. Fix this by de-duping instead on span.URI. Change-Id: Iedadfac17a0a993570ff4f8301a97815477f1c2c Reviewed-on: https://go-review.googlesource.com/c/tools/+/254117 Run-TryBot: Robert Findley <rfindley@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> gopls-CI: kokoro <noreply+kokoro@google.com> Reviewed-by: Heschi Kreinick <heschi@google.com> (cherry picked from commit 571a207697e7c073370297b1f73b9fbd7682a851) Reviewed-on: https://go-review.googlesource.com/c/tools/+/254217
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc and vet for example, are included in binary Go distributions.
Others, including the Go guru and the test coverage tool, can be fetched with go get.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/.... You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools.
This repository uses prettier to format JS and CSS files.
The version of prettier used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.