tree 984a7c5eff72ff3acc7018880ca10522f3182aa9
parent 47985cf3c742a03b71ec7bc1884c4bae906cd5ab
author Heschi Kreinick <heschi@google.com> 1614378087 -0500
committer Heschi Kreinick <heschi@google.com> 1614650713 +0000

internal/lsp/cache: split up sourceDiagnostics

In practice, the only code shared among the various switch cases was the
call to spanToRange, which definitely doesn't justify the giant
function. Split it out into per-type functions.

I removed the unused case for types.Error, and a bit of error checking I
believe to be redundant. I don't intend any functional changes.

At this point it might be worth considering moving the functions into
other files, but I don't think it matters that much.

Change-Id: I05b4d86dd37a9ff1887a116183c915c225faf3a7
Reviewed-on: https://go-review.googlesource.com/c/tools/+/297129
Trust: Heschi Kreinick <heschi@google.com>
Run-TryBot: Heschi Kreinick <heschi@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>