| commit | 78002535c3393fa16bbc5f5d9394a4041606bca4 | [log] [tgz] |
|---|---|---|
| author | Heschi Kreinick <heschi@google.com> | Fri Feb 26 17:21:27 2021 -0500 |
| committer | Heschi Kreinick <heschi@google.com> | Tue Mar 02 02:05:13 2021 +0000 |
| tree | 984a7c5eff72ff3acc7018880ca10522f3182aa9 | |
| parent | 47985cf3c742a03b71ec7bc1884c4bae906cd5ab [diff] |
internal/lsp/cache: split up sourceDiagnostics In practice, the only code shared among the various switch cases was the call to spanToRange, which definitely doesn't justify the giant function. Split it out into per-type functions. I removed the unused case for types.Error, and a bit of error checking I believe to be redundant. I don't intend any functional changes. At this point it might be worth considering moving the functions into other files, but I don't think it matters that much. Change-Id: I05b4d86dd37a9ff1887a116183c915c225faf3a7 Reviewed-on: https://go-review.googlesource.com/c/tools/+/297129 Trust: Heschi Kreinick <heschi@google.com> Run-TryBot: Heschi Kreinick <heschi@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc and vet for example, are included in binary Go distributions.
Others, including the Go guru and the test coverage tool, can be fetched with go get.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/.... You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools.
This repository uses prettier to format JS and CSS files.
The version of prettier used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.