)]}' { "commit": "76a79a66c359644e671a64f8c954f4e42ee3ff57", "tree": "94d55d1f87d1125d322f64170e84606a3c4912c7", "parents": [ "7e5cd543786c8097b63dcd376c0cf93de57a4368" ], "author": { "name": "Rob Findley", "email": "rfindley@google.com", "time": "Wed Sep 30 23:37:47 2020 -0400" }, "committer": { "name": "Robert Findley", "email": "rfindley@google.com", "time": "Fri Oct 02 18:00:38 2020 +0000" }, "message": "internal/lsp/source: factor out enum options pattern\n\nFactor out processing of string enums when setting options results. In a\ncouple places this will result in errors being detected for invalid\nvalues where they weren\u0027t before. Interestingly the default branch for\nsymbolMatcher was \u0027caseInsensitive\u0027, when in fact the default matcher in\nthe absence of any setting is \u0027fuzzy\u0027. The command tests were implicitly\nrelying on this bug, passing \u0027default\u0027 to mean \u0027caseInsensitive\u0027. Fix\nthis.\n\nAlso add a test, since option processing is not trivial.\n\nChange-Id: Ib3ec4b1619add4c7315b6a689ca257e068da6027\nReviewed-on: https://go-review.googlesource.com/c/tools/+/258658\nRun-TryBot: Robert Findley \u003crfindley@google.com\u003e\ngopls-CI: kokoro \u003cnoreply+kokoro@google.com\u003e\nTryBot-Result: Go Bot \u003cgobot@golang.org\u003e\nReviewed-by: Rebecca Stambler \u003crstambler@golang.org\u003e\nTrust: Robert Findley \u003crfindley@google.com\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "e1c374ca124e25fcc9e334387c12382eaa83f729", "old_mode": 33188, "old_path": "internal/lsp/cmd/cmd.go", "new_id": "c9f038fbee5fe6cfb484f37e3d1a3f99c7bc39f9", "new_mode": 33188, "new_path": "internal/lsp/cmd/cmd.go" }, { "type": "modify", "old_id": "6b19e344a3acdecf54db75a88279d36c028569e9", "old_mode": 33188, "old_path": "internal/lsp/cmd/test/workspace_symbol.go", "new_id": "796dfb8613e0e0cf2223f07f79a68ca5be9c91e7", "new_mode": 33188, "new_path": "internal/lsp/cmd/test/workspace_symbol.go" }, { "type": "modify", "old_id": "653ec5e30d3726cc8daae179bd5c01ab0e09b380", "old_mode": 33188, "old_path": "internal/lsp/source/options.go", "new_id": "615de2ea0b49c2d3043f366411ecfa013f0650a0", "new_mode": 33188, "new_path": "internal/lsp/source/options.go" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "0e686b6639fc3c82b30d68cf9076bf9b9a499c3a", "new_mode": 33188, "new_path": "internal/lsp/source/options_test.go" } ] }