| commit | 76a79a66c359644e671a64f8c954f4e42ee3ff57 | [log] [tgz] |
|---|---|---|
| author | Rob Findley <rfindley@google.com> | Wed Sep 30 23:37:47 2020 -0400 |
| committer | Robert Findley <rfindley@google.com> | Fri Oct 02 18:00:38 2020 +0000 |
| tree | 94d55d1f87d1125d322f64170e84606a3c4912c7 | |
| parent | 7e5cd543786c8097b63dcd376c0cf93de57a4368 [diff] |
internal/lsp/source: factor out enum options pattern Factor out processing of string enums when setting options results. In a couple places this will result in errors being detected for invalid values where they weren't before. Interestingly the default branch for symbolMatcher was 'caseInsensitive', when in fact the default matcher in the absence of any setting is 'fuzzy'. The command tests were implicitly relying on this bug, passing 'default' to mean 'caseInsensitive'. Fix this. Also add a test, since option processing is not trivial. Change-Id: Ib3ec4b1619add4c7315b6a689ca257e068da6027 Reviewed-on: https://go-review.googlesource.com/c/tools/+/258658 Run-TryBot: Robert Findley <rfindley@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org> Trust: Robert Findley <rfindley@google.com>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc and vet for example, are included in binary Go distributions.
Others, including the Go guru and the test coverage tool, can be fetched with go get.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/.... You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools.
This repository uses prettier to format JS and CSS files.
The version of prettier used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.