| commit | 2364a5e8fdcfea4b60a58838bcdf0a007a62bf15 | [log] [tgz] |
|---|---|---|
| author | Olivier Wulveryck <olivier.wulveryck@gmail.com> | Wed Aug 19 21:14:08 2020 +0200 |
| committer | Dmitri Shuralyov <dmitshur@golang.org> | Thu Sep 03 00:54:29 2020 +0000 |
| tree | f57868a59fb64788ad9d44ad704b762621efbd17 | |
| parent | cf7880770c1e80a90b5973b87c1583154b05af5f [diff] |
playground/socket: remove the os cleanup from start method of process The cleaning process happens in the end method of process, after cmd.Wait. Deleting it early while the cmd is still running is causing issues for security tools. Move the assignment of p.path along with its comment to happen earlier, after the temporary directory is created. It clarifies that the lack of call to os.RemoveAll is not a mistake. Fixes golang/go#40902 Change-Id: I0e555c58893c64a0de5880a5e12e6ff2e01b1eec Reviewed-on: https://go-review.googlesource.com/c/tools/+/249777 Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org> Reviewed-by: Alexander Rakoczy <alex@golang.org>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc and vet for example, are included in binary Go distributions.
Others, including the Go guru and the test coverage tool, can be fetched with go get.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/.... You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools.
This repository uses prettier to format JS and CSS files.
The version of prettier used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.