gopls/internal/lsp/cache: delete Snapshot.KnownPackages
It is redundant w.r.t. AllValidMetadata (now named AllMetadata)
followed by TypeCheck.
Change-Id: Ibca1516e3d9f036e4d2682b43cd73c29e8d5d981
Reviewed-on: https://go-review.googlesource.com/c/tools/+/456975
Run-TryBot: Alan Donovan <adonovan@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
Reviewed-by: Robert Findley <rfindley@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
diff --git a/gopls/internal/lsp/cache/snapshot.go b/gopls/internal/lsp/cache/snapshot.go
index 88ae7fe..c518aca 100644
--- a/gopls/internal/lsp/cache/snapshot.go
+++ b/gopls/internal/lsp/cache/snapshot.go
@@ -1136,27 +1136,7 @@
return result
}
-func (s *snapshot) KnownPackages(ctx context.Context) ([]source.Package, error) {
- if err := s.awaitLoaded(ctx); err != nil {
- return nil, err
- }
-
- s.mu.Lock()
- g := s.meta
- s.mu.Unlock()
-
- pkgs := make([]source.Package, 0, len(g.metadata))
- for id := range g.metadata {
- pkg, err := s.checkedPackage(ctx, id, s.workspaceParseMode(id))
- if err != nil {
- return nil, err
- }
- pkgs = append(pkgs, pkg)
- }
- return pkgs, nil
-}
-
-func (s *snapshot) AllValidMetadata(ctx context.Context) ([]*source.Metadata, error) {
+func (s *snapshot) AllMetadata(ctx context.Context) ([]*source.Metadata, error) {
if err := s.awaitLoaded(ctx); err != nil {
return nil, err
}
