)]}' { "commit": "74f2986df7b4643d9ccd54d311e29dd344b3da95", "tree": "dca49a113b179872e4aad1068e077aa80f8807cd", "parents": [ "1d699438d2cfa7860063cbaad653902484e42774" ], "author": { "name": "Rebecca Stambler", "email": "rstambler@golang.org", "time": "Tue Nov 10 00:13:20 2020 -0500" }, "committer": { "name": "Rebecca Stambler", "email": "rstambler@golang.org", "time": "Tue Nov 17 01:39:53 2020 +0000" }, "message": "internal/lsp: show critical error pop-ups as progress reports\n\nWe\u0027ve been looking for a way to show unintrusive error status reports to\nusers--try using progress reports as a way of populating a status bar.\nThis avoids the problem of annoying the user with constant pop-ups.\n\nWhenever an error is returns from (*snapshot).WorkspacePackages, we\nstart a progress report with the error message. If the error goes away\non the next call to diagnostics, or the error message changes, we will\neither remove or update the progress report.\n\nScreencast: https://drive.google.com/file/d/1tG9pc_tPsLoqkQHiJqdY8b06TzTkPVae/view?usp\u003dsharing\u0026resourcekey\u003d0-CEG_LhGHYiFp9S37ut_kgw\n\nUpdates golang/go#42250\n\nChange-Id: I8a529a911883092bc08af32246719d883dc5f5a2\nReviewed-on: https://go-review.googlesource.com/c/tools/+/268677\nTrust: Rebecca Stambler \u003crstambler@golang.org\u003e\nRun-TryBot: Rebecca Stambler \u003crstambler@golang.org\u003e\ngopls-CI: kokoro \u003cnoreply+kokoro@google.com\u003e\nTryBot-Result: Go Bot \u003cgobot@golang.org\u003e\nReviewed-by: Heschi Kreinick \u003cheschi@google.com\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "a19394eebda11f4c7b0f9e4808945d7073c7a7a2", "old_mode": 33188, "old_path": "gopls/internal/regtest/diagnostics_test.go", "new_id": "e3bd93f930ef4789ca6edd3ee310f7f257ca4bf5", "new_mode": 33188, "new_path": "gopls/internal/regtest/diagnostics_test.go" }, { "type": "modify", "old_id": "f1b958d8e5979824f1ad7cb21256f12985840532", "old_mode": 33188, "old_path": "gopls/internal/regtest/env.go", "new_id": "70859fd3b6e722b95a7c2964fd2a1082bd66586b", "new_mode": 33188, "new_path": "gopls/internal/regtest/env.go" }, { "type": "modify", "old_id": "efc5ffb1c2bea415f326576d32ffc6f8248c5485", "old_mode": 33188, "old_path": "gopls/internal/regtest/expectation.go", "new_id": "f895e8cbf9f6c3d31b3b5e78fbd77065d9609b27", "new_mode": 33188, "new_path": "gopls/internal/regtest/expectation.go" }, { "type": "modify", "old_id": "c54bdaaf91565743c24d96b8cf6cd155a49a3837", "old_mode": 33188, "old_path": "internal/lsp/diagnostics.go", "new_id": "f821361a2a18bfe15a0c0276b8add0d6b1ed52ab", "new_mode": 33188, "new_path": "internal/lsp/diagnostics.go" }, { "type": "modify", "old_id": "c2f5004756684ab79e431ca3d2fb831e39294bda", "old_mode": 33188, "old_path": "internal/lsp/server.go", "new_id": "905a4081ba247c8ae6b385092ea93981c5374309", "new_mode": 33188, "new_path": "internal/lsp/server.go" } ] }