tree 3816ff2bf80a34d7cb0bd144044db1f8049192e2
parent fa491999fbfe4e54000520294779f2944b8ef912
author Ian Cottrell <iancottrell@google.com> 1554729778 -0400
committer Ian Cottrell <iancottrell@google.com> 1555360296 +0000

internal/lsp: normalise and make public diff<->edit conversions

This allows us to use the diff.ApplyEdits in tests, saving us from a different
implementation.
It also prepares for command lines that need to use diff features based on the
results of a protocol message.

Splitting content into lines is too easy to get wrong, and needs to be done
correctly or the diff results make no sense. This adds the SplitLines function
to the diff pacakge to do it right and then uses it everwhere we we already
doing it wrong.

It also makes all the diff tests external black box tests.

Change-Id: I698227d5769a2bfbfd22a64ea42906b1df9268d9
Reviewed-on: https://go-review.googlesource.com/c/tools/+/171027
Run-TryBot: Ian Cottrell <iancottrell@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>