tree 53166f005b0f9ee372b15acd12d90dbe7687562d
parent 4e31bdea7810f35a2654fd9a81602f35d437d00f
author Robert Findley <rfindley@google.com> 1642106311 -0500
committer Robert Findley <rfindley@google.com> 1642179662 +0000

internal/lsp/cache: fix check for excluded paths in locateTemplateFiles

The pathExcludedByFilter helper function expects path to be relative to
the workspace folder. This is a confusing API, and led to us passing
absolute paths when checking for excluded template files.

Fix it, add a regtest, and add a TODO to clean up the API.

Fixes golang/go#50431

Change-Id: Iedcf0dd9710e541c9fb8c296d9856a13ef3fbcb6
Reviewed-on: https://go-review.googlesource.com/c/tools/+/378398
Trust: Robert Findley <rfindley@google.com>
Run-TryBot: Robert Findley <rfindley@google.com>
Reviewed-by: Ian Cottrell <iancottrell@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>