| commit | 73b12cab2531d716d7df68317338773313a49bac | [log] [tgz] |
|---|---|---|
| author | André Martins <aanm90@gmail.com> | Thu Jul 30 15:32:02 2020 +0200 |
| committer | Rebecca Stambler <rstambler@golang.org> | Mon Aug 10 15:05:53 2020 +0000 |
| tree | 40ea44e0f52edc2587c724fbc399bfb2275756a1 | |
| parent | 3e8281990cc27a01b501b40ab7bf665e238c3f28 [diff] |
go/analysis/passes/structtag: ignore warning if tag should be ignored Having a private field with a json tag does not necessary means the field needs to be exposed publicly. This change ignores the warning of such fields that contain a json tag with the field tag "-". The lines added in the unit tests will fail without these changes with the error: ``` a/a.go:36:2: unexpected diagnostic: struct field b has json tag but is not exported ``` Change-Id: Ife987b99c264ae3b60a702e43a1f9c778f8c2d62 Reviewed-on: https://go-review.googlesource.com/c/tools/+/245857 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc and vet for example, are included in binary Go distributions.
Others, including the Go guru and the test coverage tool, can be fetched with go get.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/.... You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools.
This repository uses prettier to format JS and CSS files.
The version of prettier used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.