commit | 72f2e0bf6de7ef4a34315541b8da70247f5ec563 | [log] [tgz] |
---|---|---|
author | Josh Baum <joshbaum@google.com> | Fri Aug 07 15:54:09 2020 -0400 |
committer | Josh Baum <joshbaum@google.com> | Mon Aug 10 22:02:59 2020 +0000 |
tree | c4f21588986d23e72132269ed2197bbd36122386 | |
parent | c1903db4dbfe5ab8e2ec704e203535dae53c2adc [diff] |
internal/lsp: limit code action false positives for extract to variable Instead of only checking whether the selection is an AST expression in canExtractVariable, we now also check what kind of AST expression it is. This limits the frequency of situations where the lightbulb appears (canExtractVariable succeeds), but nothing can be extracted (extractVariable fails). Change-Id: I1e63c982e482bb72df48b414bdb4e8037140afdb Reviewed-on: https://go-review.googlesource.com/c/tools/+/247408 Run-TryBot: Josh Baum <joshbaum@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc
and vet
for example, are included in binary Go distributions.
Others, including the Go guru
and the test coverage tool, can be fetched with go get
.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/...
. You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools
.
This repository uses prettier to format JS and CSS files.
The version of prettier
used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.