| commit | 251f28368628a338a6504f358a488012529e98d5 | [log] [tgz] |
|---|---|---|
| author | Rob Findley <rfindley@google.com> | Fri Apr 09 12:20:39 2021 -0400 |
| committer | Robert Findley <rfindley@google.com> | Thu Jul 08 19:55:54 2021 +0000 |
| tree | 5a2978611182106bb7f9ca0ff3388588a1f72804 | |
| parent | c979f9254a9be60d4e53e9d55534fc5211b079a1 [diff] |
internal/lsp: add a setting to batch didChangeWatchedFile notifications Gopls's serial processing of didChangeWatchedFile notifications has historically been a pain point for clients that don't batch file events, when branch switching or running go generate. It's "not that tricky" for us to debounce and batch up watched file notifications on our end, so this CL introduces this functionality as a new experimental setting. Truth be told it ended up being harder than expected, due to (1) our requirement for regtests to be able to determine when diagnostics have completed, and (2) our reliance on jsonrpc2 for sequencing changes to the server. To address (1), I factored out the actual processing of change notifications into a separate method (thus increasing our surprisingly long chain of method calls). To address (2), I guarded the processing of file changes with a mutex. I also guarded some places where views and snapshots were accessed in potentially racy ways. Our interaction with session.views was rather complicated, so I had to switch session.viewsMu to a RWMutex. Add this to the experimental regtest mode, and more generally enable all experimental features in this mode, rather than just the experimental workspace module. Fixes golang/go#41691 Change-Id: Ifccdbdf86263dbe2e37ffe9f7bbf2a2cd74218b4 Reviewed-on: https://go-review.googlesource.com/c/tools/+/309269 Trust: Robert Findley <rfindley@google.com> Trust: Rebecca Stambler <rstambler@golang.org> Run-TryBot: Robert Findley <rfindley@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Heschi Kreinick <heschi@google.com>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc and vet for example, are included in binary Go distributions.
Others, including the Go guru and the test coverage tool, can be fetched with go get.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/.... You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools.
This repository uses prettier to format JS and CSS files.
The version of prettier used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.