tree 2bb1a9ee7623d6742e8cc4a0cd7788ffeb1e542e
parent 1e5ae8399a2b4c8019e7ff391e820ed744d68c56
author Robert Findley <rfindley@google.com> 1648156407 -0400
committer Robert Findley <rfindley@google.com> 1648222010 +0000

internal/lsp/source: descend into fields and field lists in qualifyExpr

We do a lot of gymnastics to format var types, working around the lack
of alias tracking in go/types. As part of this, we clone and qualify
expressions. In this case, we were not qualifying identifiers that were
contained within fields or field lists.

Fix this by updating our expression traversal to include *ast.Field and
*ast.FieldList.

Fixes golang/go#50539

Change-Id: I6531c6a51aa402bd784778b8bedaa3dccee75af0
Reviewed-on: https://go-review.googlesource.com/c/tools/+/395678
Trust: Robert Findley <rfindley@google.com>
Run-TryBot: Robert Findley <rfindley@google.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>