tree 30b979e42aaee59f0f4e1cf3062f2ff3ba59babb
parent 7c0525f22978c0a67c3a74385d9f06dff8db0268
author Muir Manders <muir@mnd.rs> 1596865858 -0700
committer Rebecca Stambler <rstambler@golang.org> 1597509096 +0000

internal/lsp/source: improve completion in append()

In the following example:

    var foo []someStruct
    foo = append(foo, <>)

we now downrank "foo" as a candidate at "<>". You very rarely append a
slice to itself, so having "foo" ranked highly was counterproductive.

Fixes golang/go#40535.

Change-Id: Ic01366aeded4ba2b6b64bfddd33415499b35a323
Reviewed-on: https://go-review.googlesource.com/c/tools/+/247519
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>