commit | 598b068a910218bc1de6b0ec0c61ff245d140a54 | [log] [tgz] |
---|---|---|
author | Rebecca Stambler <rstambler@golang.org> | Tue Nov 17 18:05:09 2020 -0500 |
committer | Rebecca Stambler <rstambler@golang.org> | Wed Nov 18 03:03:13 2020 +0000 |
tree | b669c4bb088e8e1d5e98ec9a934e32065dd2c3b0 | |
parent | bd56c0adb394dbf4ed40c38f904161b162595069 [diff] |
internal/lsp: fix end positions for multi-line comments with CRLF lines The previous work-around assumed that the end of the comment would be off by one line, when in reality, it is off by the offset of the number of \r in the comment, which may result in the comment end position being off by multiple lines. Work around this by scanning for the end of the comment position using text/scanner. Fixes golang/go#42646 Change-Id: Icc33e889546f324c6b65b55a98dea587f84c8f01 Reviewed-on: https://go-review.googlesource.com/c/tools/+/270879 Trust: Rebecca Stambler <rstambler@golang.org> Run-TryBot: Rebecca Stambler <rstambler@golang.org> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Robert Findley <rfindley@google.com>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc
and vet
for example, are included in binary Go distributions.
Others, including the Go guru
and the test coverage tool, can be fetched with go get
.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/...
. You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools
.
This repository uses prettier to format JS and CSS files.
The version of prettier
used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.